Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Aspen Consumer Configuration Panel #1239

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Adding Aspen Consumer Configuration Panel #1239

merged 7 commits into from
Sep 24, 2024

Conversation

sotorrio1
Copy link
Member

Fixes/Addresses:

It addresses issue #1199

Summary/Motivation:

Sometimes the user might want to modify the timeout parameters in Aspen. Instead of making the user to go and modify an XML file, this panel helps them just type in a number and FOQUS will update the configuration file with the click of a button.

Changes proposed in this PR:

  • added tab to the node panel with a table that gets populated with the current values in the configuration file.
  • added logic so the user can modify the values and the file gets updated correctly

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@sotorrio1 sotorrio1 added the Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab label Sep 12, 2024
@sotorrio1 sotorrio1 requested a review from boverhof September 12, 2024 19:12
@sotorrio1 sotorrio1 self-assigned this Sep 12, 2024
@sotorrio1 sotorrio1 linked an issue Sep 12, 2024 that may be closed by this pull request
Configuration Panel: Add Timeouts for AspenConsumer #1199
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.91304% with 70 lines in your changes missing coverage. Please review.

Project coverage is 38.75%. Comparing base (b778e7f) to head (075fa63).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
foqus_lib/gui/flowsheet/nodePanel.py 23.91% 69 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
- Coverage   38.79%   38.75%   -0.04%     
==========================================
  Files         164      164              
  Lines       37048    37139      +91     
  Branches     6153     6164      +11     
==========================================
+ Hits        14371    14392      +21     
- Misses      21542    21611      +69     
- Partials     1135     1136       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Sep 24, 2024
@boverhof boverhof self-assigned this Sep 24, 2024
@boverhof boverhof merged commit 0db11e9 into CCSI-Toolset:master Sep 24, 2024
28 checks passed
@sotorrio1 sotorrio1 mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boverhof boverhof Awaiting requested review from boverhof

Assignees

@boverhof boverhof

@sotorrio1 sotorrio1

Labels
Flowsheet Issues related to setting up, & running process models for simulation in the Flowsheet tab Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration Panel: Add Timeouts for AspenConsumer
3 participants
@sotorrio1 @boverhof @ksbeattie